Skip to content

HADOOP-18916. Exclude all module-info classes from uber jars (#6131)#6188

Merged
ayushtkn merged 1 commit intoapache:branch-3.3from
pjfanning:HADOOP-18916-backport
Oct 14, 2023
Merged

HADOOP-18916. Exclude all module-info classes from uber jars (#6131)#6188
ayushtkn merged 1 commit intoapache:branch-3.3from
pjfanning:HADOOP-18916-backport

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Oct 13, 2023

Removes java9 and java11 from all modules pulled into the hadoop-client and hadoop-client-minicluster modules.

Description of PR

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@pjfanning
HADOOP-18916. Exclude all module-info classes from uber jars (apache#…
ff65f89 
…6131)

Removes java9 and java11 from all modules pulled into the hadoop-client
and hadoop-client-minicluster modules.

Contributed by PJ Fanning
@hadoop-yetus
Copy link

hadoop-yetus commented Oct 13, 2023

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 15m 16s Maven dependency ordering for branch
+1 💚 mvninstall 40m 14s branch-3.3 passed
+1 💚 compile 0m 22s branch-3.3 passed
+1 💚 mvnsite 0m 46s branch-3.3 passed
+1 💚 javadoc 0m 44s branch-3.3 passed
+1 💚 shadedclient 97m 50s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for patch
+1 💚 mvninstall 20m 24s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 30s the patch passed
+1 💚 javadoc 0m 28s the patch passed
+1 💚 shadedclient 40m 29s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 16s hadoop-client-runtime in the patch passed.
+1 💚 unit 0m 17s hadoop-client-minicluster in the patch passed.
+1 💚 asflicense 0m 33s The patch does not generate ASF License warnings.
166m 11s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6188/1/artifact/out/Dockerfile
GITHUB PR #6188
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 334f4d0d78b1 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / ff65f89
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu118.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6188/1/testReport/
Max. process+thread count 527 (vs. ulimit of 5500)
modules C: hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: hadoop-client-modules
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6188/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@pjfanning pjfanning mentioned this pull request Oct 13, 2023
Merged
ayushtkn
ayushtkn approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushtkn ayushtkn merged commit 553b8ff into apache:branch-3.3 Oct 14, 2023
@JiaLiangC JiaLiangC mentioned this pull request Apr 23, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pjfanning @hadoop-yetus @ayushtkn